https://bugzilla.redhat.com/show_bug.cgi?id=1172210 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source0 archive is original (SHA-256: 3e0ad1d850880e3f79b7dd70f25234108b4185aa53c3ccccd6acebecf4b66722). Ok. Summary verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok. Description verified from lib/Git/Repository/Plugin/AUTOLOAD.pm. Ok. License verified from lib/Git/Repository/Plugin/AUTOLOAD.pm and LICESNE. Ok. No XS code, noarch BuildArch is Ok. All build-time dependencies are specified. Ok. All tests pass. $ rpmlint perl-Git-Repository-Plugin-AUTOLOAD.spec ../SRPMS/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.src.rpm ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands perl-Git-Repository-Plugin-AUTOLOAD.src: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error Summary(en_US) subcommands -> sub commands, sub-commands, commands perl-Git-Repository-Plugin-AUTOLOAD.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD -rw-r--r-- 1 root root 296 Feb 23 2014 /usr/share/doc/perl-Git-Repository-Plugin-AUTOLOAD/Changes drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD -rw-r--r-- 1 root root 18377 Feb 23 2014 /usr/share/licenses/perl-Git-Repository-Plugin-AUTOLOAD/LICENSE -rw-r--r-- 1 root root 2164 Dec 9 17:12 /usr/share/man/man3/Git::Repository::Plugin::AUTOLOAD.3pm.gz drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git/Repository drwxr-xr-x 2 root root 0 Dec 9 17:12 /usr/share/perl5/vendor_perl/Git/Repository/Plugin -rw-r--r-- 1 root root 2617 Feb 23 2014 /usr/share/perl5/vendor_perl/Git/Repository/Plugin/AUTOLOAD.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl >= 0:5.006 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Git::Repository::Plugin) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Git::Repository::Plugin::AUTOLOAD) = 1.001 1 perl-Git-Repository-Plugin-AUTOLOAD = 1.001-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Git-Repository-Plugin-AUTOLOAD-1.001-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8330045). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review