https://bugzilla.redhat.com/show_bug.cgi?id=1170720 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> --- The mingw-hicolor-icon-theme packages own all the directories that are warned about below, so this looks fine to me! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in mingw32-colorhug-client, mingw64-colorhug-client See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema I can see the glib-compile-schemas calls in the .spec, so this is bogus. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1170720-mingw-colorhug-client/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/24x24, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/apps, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48, /usr/i686-w64-mingw32/sys- root/mingw/share/icons, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/scalable/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/256x256/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/scalable/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/64x64/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/24x24/mimetypes, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/scalable, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/22x22/apps, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/16x16, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/24x24/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22/mimetypes, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/16x16/mimetypes, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/64x64, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/apps, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/scalable/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/64x64/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/48x48, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/256x256, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/32x32/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/32x32, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/32x32/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/24x24/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/scalable, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/22x22, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/24x24, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16/apps, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/64x64, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/64x64/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/16x16/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/16x16/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/64x64/mimetypes, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/22x22/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/22x22/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24/apps [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/apps, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/48x48/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/64x64/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/256x256/apps, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/scalable, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/scalable/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/64x64/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/16x16/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/256x256/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/22x22, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/64x64, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/64x64/mimetypes, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/48x48, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32/apps, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16/apps, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/48x48, /usr/i686-w64-mingw32/sys- root/mingw/share/icons, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/48x48/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24/mimetypes, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22/mimetypes, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/256x256, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/64x64/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/256x256/apps, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/32x32/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/22x22/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/256x256, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/22x22/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/32x32/mimetypes, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/64x64, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/16x16/mimetypes, /usr/x86_64-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/48x48/apps, /usr/i686-w64-mingw32 /sys-root/mingw/share/icons/hicolor/24x24/apps [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32 -colorhug-client , mingw64-colorhug-client [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-colorhug-client-0.2.4-1.fc22.noarch.rpm mingw64-colorhug-client-0.2.4-1.fc22.noarch.rpm mingw-colorhug-client-0.2.4-1.fc22.src.rpm mingw32-colorhug-client.noarch: W: spelling-error %description -l en_US colorimeter -> cyclometer mingw32-colorhug-client.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-colorhug-client.noarch: W: spelling-error %description -l en_US colorimeter -> cyclometer mingw64-colorhug-client.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-colorhug-client.src: W: spelling-error %description -l en_US colorimeter -> cyclometer 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# rpmlint mingw64-colorhug-client mingw32-colorhug-client mingw64-colorhug-client.noarch: W: spelling-error %description -l en_US colorimeter -> cyclometer mingw32-colorhug-client.noarch: W: spelling-error %description -l en_US colorimeter -> cyclometer 2 packages and 0 specfiles checked; 0 errors, 2 warnings. ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# echo 'rpmlint-done:' Requires -------- mingw64-colorhug-client (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libcairo-2.dll) mingw64(libcolord-2.dll) mingw64(libcolord-gtk-1.dll) mingw64(libcolordprivate-2.dll) mingw64(libcolorhug-2.dll) mingw64(libgdk-3-0.dll) mingw64(libgdk_pixbuf-2.0-0.dll) mingw64(libgio-2.0-0.dll) mingw64(libglib-2.0-0.dll) mingw64(libgobject-2.0-0.dll) mingw64(libgtk-3-0.dll) mingw64(libgusb-2.dll) mingw64(libintl-8.dll) mingw64(libpango-1.0-0.dll) mingw64(libpangocairo-1.0-0.dll) mingw64(libsoup-2.4-1.dll) mingw64(msvcrt.dll) mingw64-adwaita-icon-theme mingw64-crt mingw64-filesystem mingw64-glib-networking mingw64-hicolor-icon-theme mingw64-librsvg2 mingw32-colorhug-client (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libcairo-2.dll) mingw32(libcolord-2.dll) mingw32(libcolord-gtk-1.dll) mingw32(libcolordprivate-2.dll) mingw32(libcolorhug-2.dll) mingw32(libgdk-3-0.dll) mingw32(libgdk_pixbuf-2.0-0.dll) mingw32(libgio-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(libgtk-3-0.dll) mingw32(libgusb-2.dll) mingw32(libintl-8.dll) mingw32(libpango-1.0-0.dll) mingw32(libpangocairo-1.0-0.dll) mingw32(libsoup-2.4-1.dll) mingw32(libwinpthread-1.dll) mingw32(msvcrt.dll) mingw32-adwaita-icon-theme mingw32-crt mingw32-filesystem mingw32-glib-networking mingw32-hicolor-icon-theme mingw32-librsvg2 Provides -------- mingw64-colorhug-client: mingw64-colorhug-client mingw32-colorhug-client: mingw32-colorhug-client Source checksums ---------------- http://people.freedesktop.org/~hughsient/releases/colorhug-client-0.2.4.tar.xz : CHECKSUM(SHA256) this package : 44bf093735a1457cc3b601349d85b4124c79746f47b419a0a079a372de61be03 CHECKSUM(SHA256) upstream package : 44bf093735a1457cc3b601349d85b4124c79746f47b419a0a079a372de61be03 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --local-repo /home/david/Downloads/ -b 1170720 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Built with local dependencies: /home/david/Downloads/mingw64-hicolor-icon-theme-0.13-1.fc22.noarch.rpm /home/david/Downloads/mingw32-hicolor-icon-theme-0.13-1.fc22.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review