Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dfu-programmer - USB DFU based programmer for Atmel chips https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211761 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-05-06 00:56 EST ------- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: FC-6 / i386 [!] Rpmlint output: W: dfu-programmer incoherent-version-in-changelog 0.3.1-1 0.4.1-1.fc6 [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 100113bd773ec1a6a6a0e67cde928b6e MD5SUM upstream package: 197e49052a305ee3677f2ef95a1390c9 [x] Package is not known to require ExcludeArch, OR: Arches excluded: Why: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: FC-6 / i386 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: koji dist-fc7 [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. %changelog versions is not in sync with actual version. 2. Source0 should be a download URL. Please see http://fedoraproject.org/wiki/PackagingDrafts/SourceUrl#head-27442167fe28eb345470e8db56716d62b508978c 3. Normally, you'd want to use the equivalent of wget -N to download the source tarball, but since you'd upstream, you would want to do whatever you should to preserver the original timestamp to pack into the SRPM. 4. md5sum of the included tarball and the upstream tarball do not match. That's not good ;) === Final Notes === 1. If you are only supporting Fedora, you don't need to specify >= 0.1.10a for your libusb (FC5 is lowest supported and it's 0.1.11). If you want to support other distros or even EPEL, then you should leave it as is. 2. If your package requires kernel support at a specific version, you'd want to add that as a requirement as well. I don't have enough documentation to determine if that is the case or not. If you have any questions about these comments, let me know. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review