https://bugzilla.redhat.com/show_bug.cgi?id=1141529 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL 5 bits after initial import. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). W: conffile-without-noreplace-flag /etc/horde/passwd/conf.xml %attr(0660,apache,apache) %config %{_sysconfdir}/horde/%{pear_name}/*.xml Since the permission of this config file is 0660 instead of 0640, it implies that this file can be edited by end-users. However, without "%config(noreplace)" end-users' edits would be lost. Just a warning, but you may want to address this. No blockers. ===== APPROVED ===== -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review