[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1170816

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---

Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-astral-angular-annotate.noarch: W: only-non-binary-in-usr-lib
nodejs-astral-angular-annotate.noarch: W: dangling-symlink
/usr/lib/node_modules/astral-angular-annotate/node_modules/astral-pass
/usr/lib/node_modules/astral-pass
nodejs-astral-angular-annotate.noarch: W: dangling-symlink
/usr/lib/node_modules/astral-angular-annotate/node_modules/clone
/usr/lib/node_modules/clone
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 9752eac4723557b1983f4b1f45539a3e08e62683c7e669c2ae0814bf57cbbc66
upstream tarball: 
9752eac4723557b1983f4b1f45539a3e08e62683c7e669c2ae0814bf57cbbc66

+ License is "MIT" 

- License text is not included.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group is optional, can be removed.

2) Ask upstream to add license text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]