[Bug 1169121] Review Request: nodejs-domhandler - Handler for htmlparser2 that turns pages into a dom

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1169121

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-domhandler.noarch: W: spelling-error Summary(en_US) dom -> mod, dim, don
nodejs-domhandler.noarch: W: spelling-error %description -l en_US dom -> mod,
dim, don
nodejs-domhandler.noarch: W: only-non-binary-in-usr-lib
nodejs-domhandler.noarch: W: dangling-symlink
/usr/lib/node_modules/domhandler/node_modules/domelementtype
/usr/lib/node_modules/domelementtype
nodejs-domhandler.src: W: spelling-error Summary(en_US) dom -> mod, dim, don
nodejs-domhandler.src: W: spelling-error %description -l en_US dom -> mod, dim,
don
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 526cb3635c411ee00bc222897010cecf3a5cbbe0104d143c73af3265f0e85d14
upstream tarball: 
526cb3635c411ee00bc222897010cecf3a5cbbe0104d143c73af3265f0e85d14

- License is "BSD", not "MIT"

+ License text is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Fix license tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]