[Bug 1171263] Review Request: nodejs-istanbul - A JS code coverage tool written in JS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171263



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
oops! my bad. I have many tabs open and I wrote wrong review above. 
Here is correct one

Review:
- Package built successful in mock (f22 x86_64)

+ Source istanbul-0.3.2.tgz verified with upstream as (sha256sum)
srpm tarball: 95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d
upstream tarball: 
95f3d546e15b110ea75466058c6247d1fb940771ae640eb49d02ad124995920d

+ License is "BSD" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) tests are failing with error
Cannot find module '../dist/cjs/handlebars'
Error: Cannot find module '../dist/cjs/handlebars'

Please fix the tests or disable them by filing upstream issue with using tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]