[Bug 1171263] Review Request: nodejs-istanbul - A JS code coverage tool written in JS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171263



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-entities.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced
upstream tarball: 
1118cdb833068b6450d48946fb53cece6e41a3e95b29d24871898cb7a71ffced

- License is "BSD" and not "MIT. 

+ License text is included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Fix license tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]