[Bug 1170802] Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1170802

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-relateurl.noarch: W: spelling-error Summary(en_US) Minify -> Magnify
nodejs-relateurl.noarch: W: spelling-error %description -l en_US Minify ->
Magnify
nodejs-relateurl.noarch: W: only-non-binary-in-usr-lib
nodejs-relateurl.src: W: spelling-error Summary(en_US) Minify -> Magnify
nodejs-relateurl.src: W: spelling-error %description -l en_US Minify -> Magnify
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: dbcffd89b3830974076df9c9531c9705fdb5215ecf0d5c98f3afd6052bcbacaf
upstream tarball: 
dbcffd89b3830974076df9c9531c9705fdb5215ecf0d5c98f3afd6052bcbacaf

+ License is "MIT" 

- License text file is not available.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional

2) you can also write 
BuildRequires:  npm(chai)

3)Many npm modules don't used to have LICENSE text file included. You should
ask upstream to add license text file and release new upstream version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]