Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-IPv4Addr - Perl extension for manipulating IPv4 addresses Alias: perl-Net-IPv4Addr https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239159 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-05-05 19:21 EST ------- Missing BR on perl(ExtUtils::MakeMaker) and perl(Test::More); License is (by convention) generally written as "GPL or Artistic", rather than the other way around. Make the above changes, and I'll approve :) + source files match upstream: 57aa8e28ebcd4c0c9f15792740e53d3c Net-IPv4Addr-0.10.tar.gz 57aa8e28ebcd4c0c9f15792740e53d3c ../Net-IPv4Addr-0.10.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate (noarch) + %clean is present. + package installs properly + rpmlint is silent. + final provides and requires are sane: ** perl=Net-IPv4Addr-0.10-1.fc6.noarch.rpm == rpmlint == provides perl(Net::IPv4Addr) = 0.10 perl-Net-IPv4Addr = 0.10-1.fc6 == requires /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Getopt::Long) perl(Net::IPv4Addr) perl(strict) perl(vars) :lcheck is present and all tests pass + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review