https://bugzilla.redhat.com/show_bug.cgi?id=1170159 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build for f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8307001 Some comments: Both packages for Python 2 and 3 contain the man page factory_boy.1.gz. But the packages need to be independent from each other. If someone installs the py2 version, it would be impossible to also install the py3 package due to a file conflict. Either rename the man page (preferrably in the py2 package because we get py3 as default version soon) or move the man page to a sub package -common or anything similar and let the packages depend on that. Moreover, the man page is in a section where usually the man pages of executable binaries resides. But factory_boy.1 is rather a subroutine (section 3), isn't it? The package names are somewhat odd: python3-factory_boy-2.4.1-1.fc21.noarch.rpm python-factory-boy-2.4.1-1.fc21.noarch.rpm What's the reason to use either an underscore or a hyphen in the package names? The -doc subpackage requires the py2 version to be installed. This is unusual for -doc packages, unless there's no other way to launch a doc viewer than from the application itself. PKG-INFO doesn't have to be in %doc. It is included in egg-info anyway. The source tarball contains some tests, du you've tried to run them? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review