Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schismtracker - sound module composer/player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238824 ------- Additional Comments From ville.skytta@xxxxxx 2007-05-05 14:47 EST ------- Created an attachment (id=154210) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=154210&action=view) Fix remaining cosmetic issues Ok, 0.3 is looks good, approved. Remaining cosmetic issues to fix/consider before the first build: - rpmlint: W: schismtracker mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 43) - s/Skitta/Skyttä/ in the 0.5-0.3.rc1 changelog entry - Use "0%{!?_without_x:1}" instead of "%{WITH_X}" so X can be disabled using "rpmbuild --without x ...". Patch for these attached, gzipped so Bugzilla won't mangle UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review