https://bugzilla.redhat.com/show_bug.cgi?id=1135503 --- Comment #5 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- The -O3 comes from CMake's default flags for the Release build type. I think KDE 4 overrode those in FindKDE4Internal.cmake, but KF5 keeps CMake's defaults. IMHO, we should change that default in the cmake package. And yes, ANY package that uses -O3 without a good justification (and "CMake has broken defaults" is not) should not pass review. I think using RelWithDebInfo instead will make it use -O2, it may or may not have other side effects. (IIRC, we opted against defaulting to RelWithDebInfo because KDE 4 stuff only had -DNDEBUG in Release, or something like that. Not sure how KF5 behaves there.) But I insist, the default for Release should be fixed in CMake packaging. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review