https://bugzilla.redhat.com/show_bug.cgi?id=1114737 --- Comment #14 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Jerry James from comment #13) > Issues: > ======= > - The gtk-update-icon-cache invocations are being run on the main package, > but > instead should be run on the openms-TOPP package; i.e., move them to > "%posttrans TOPP" and "%postun TOPP". Done. > - The source tarball, OpenMS-Release1.11.1.tar.gz, has 0600 permissions. > Please change that to 0644. Done. > - All software in Fedora is open source, so I think the summary should just > read "LC/MS data management and analyses" Done. > - The debuginfo generator gets a little confused while trying to locate some > source files. Look in the build log for errors like this: > > cpio: > OpenMS-Release1.11.1/include/OpenMS/ANALYSIS/DECHARGING/FeatureDeconvolution. > h: Cannot stat: Permission denied > cpio: > OpenMS-Release1.11.1/include/OpenMS/ANALYSIS/DECHARGING/ILPDCWrapper.h: > Cannot stat: Permission denied > > The problem is the initial "OpenMS-Release1.11.1" part of the path. To fix > the problem, add this at the end of %install: > > ln -s . OpenMS-Release%{version} Done. > - The openms-devel package contains the directory /usr/include/OpenMS, but > there are no files inside that directory. Also, the directory has 0644 > permissions, but should have 0755 permissions. Done. > - The openms-devel package installs a symbolic link libOpenMS_GUI.so that > points to %{_libdir}/libOpenMS_GUIso.1.11.1, but the target name is > actually > %{_libdir}/libOpenMS_GUI.so.1.11.1; i.e., there is a missing dot. Done. > - ldd -u reports that the libraries and most of the binaries are linked with > libraries that are not actually used; see the > unused-direct-shlib-dependency > rpmlint warnings below. It might we worthwhile to add "-Wl,--as-needed" to > LDFLAGS. Okay. > - The cmake invocation specifies -DCMAKE_MT_ENABLE_TBB=ON and related > variables, and the spec file contains BuildRequires: tbb-devel, yet I see > this in the build log: > > -- Intel TBB: OFF > > Perhaps it should be -DMT_ENABLE_TBB=ON (without the "CMAKE_" prefix)? Done. > - Use the new %license macro to install license texts, rather than %doc. Done. > - The main package installs 80 Mbytes of files in > %{_datadir}/OpenMS/examples. > Are those files used at runtime? If not, consider moving them to a -doc > subpackage. They could be used as examples by a beginner user. > - The main package installs over 93 Mbytes of files in %{_datadir}, including > the examples. Can any of those files go into a noarch subpackage? Too sub-packages in my opinion. > - The entire %{_datadir}/OpenMS directory, except for the examples, is > duplicated in the python-openms package, as > %{python2_sitearch}/pyopenms/share/OpenMS. Is that really necessary? Can > %{python2_sitearch}/pyopenms/share/OpenMS instead be a symbolic link to > %{_datadir}/OpenMS? Python OpenMS may be used as standalone software so it must have own data directories. > - Some installed files have their executable bits set inappropriately. See > the rpmlint messages about scripts without shebangs. > - /usr/share/OpenMS/CV/psi-mzdata.obo has DOS end-of-line markers. > - Fix the description-line-too-long error in the rpmlint output. > Okay. I'm building latest release; soon i will post it. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review