https://bugzilla.redhat.com/show_bug.cgi?id=1170231 --- Comment #3 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- (In reply to Robert Scheck from comment #1) > [!]: Latest version is packaged. > -> 2195f44 available, 2fef5a4 packaged ---> The package is made from the last tagged release [1] on github, which is tagged from 2195f44. The other lines in spec-file, which refer to a particular commit on gh, are for non- / pre- / post-release builds, only. > [!]: Package does not include license text files separate from upstream. > [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. ---> See below… > [?]: Package should compile and build into binary rpms on all supported > architectures. ---> See scratch-builds on Koji from initial comment [3]. (In reply to Robert Scheck from comment #2) > Sorry for the maybe unnecessary legal request but from what I remember it > is not allowed to add/change license texts on downstream side. And patch0 > (2048-cli-0.8_minor-improvements.patch) adds the license header to all *.c > files - at least I can not see this patch upstream. ---> The patch is upstreamed, but the pull-request [2] is not merged yet. The Patch0-url in spec-file directly links to this pr. If you are more comfortable with it, I can drop the patch as well. I think it's not neccesarry to raise fe-legal here… [1] https://github.com/Tiehuis/2048-cli/releases [2] https://github.com/Tiehuis/2048-cli/pull/8 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1170231#c0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review