https://bugzilla.redhat.com/show_bug.cgi?id=1167830 --- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- (In reply to Jerry James from comment #2) > Everything looks pretty good. I've just got 2 questions: Great :) > 1. Is it just me, or are the tests not actually doing anything? Not yet, I added them in the pull request linked in comment #0. Should also have put a not to the spec, that it will be in the next version though... Sorry. > 2. The test for a Fedora that is recent enough to have python 3 is obsolete, > since the oldest supported version is currently Fedora 19. Why not make > it > read like this? > > %if 0%{?fedora} > %global with_python3 1 > %endif %changelog - Generalize with_python3 macro - Add comment to tests section Spec URL: https://tomspur.fedorapeople.org/review/python-ptyprocess.spec SRPM URL: https://tomspur.fedorapeople.org/review/python-ptyprocess-0.3.1-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review