[Bug 1142407] Review Request: drpm - deltarpm manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1142407



--- Comment #11 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> rm -f %{buildroot}%{_libdir}/libdrpm.so.0
> ln -sf libdrpm.so.0.0.0 %{buildroot}%{_libdir}/libdrpm.so.0

Provided that the SONAME for this library is set correctly, you should be able
to run

  /sbin/ldconfig -N -n %{buildroot}%{_libdir}

instead of trying to do it manually with "ln".


> %post
> /sbin/ldconfig
> 
> %postun
> /sbin/ldconfig

For plain library packages, prefer

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

which will execute ldconfig _directly_ instead of running it via /bin/sh. It
would also make the package depend on /sbin/ldconfig directly instead of
/bin/sh.


> License:        LGPLv3
> %doc COPYING

http://www.gnu.org/licenses/gpl-faq.html#v3HowToUpgrade

| If you're using LGPLv3 in your project, be sure to include copies of both
| GPLv3 and LGPLv3, since LGPLv3 is now written as a set of additional
| permissions on top of GPLv3.


> %{_datadir}/pkgconfig/drpm.pc

Wrong dir. Should be %{_libdir}.

Plus, the file contents are broken. Test them, please! The "Requires" field in
.pc files is for pkg-config inter-dependencies, _not_ for RPM dependencies.
Also check carefully which dependencies you really need when linking with
-ldrpm. You don't want to relink with libs libdrpm is linked with already, for
example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]