https://bugzilla.redhat.com/show_bug.cgi?id=1169918 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> --- Looks good to me! Discussed changes to the Adwaita directori ownership on IRC, and those will be added here and in the native package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1169918-mingw-adwaita-icon- theme/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons, /usr/i686-w64-mingw32/sys-root/mingw/share/icons, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/Adwaita, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/Adwaita [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/i686-w64-mingw32/sys- root/mingw/share/icons/Adwaita, /usr/i686-w64-mingw32/sys- root/mingw/share/icons, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/Adwaita, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32 -adwaita-icon-theme , mingw64-adwaita-icon-theme [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-adwaita-icon-theme : /usr/i686-w64-mingw32/sys- root/mingw/share/pkgconfig/adwaita-icon-theme.pc mingw64-adwaita-icon- theme : /usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig/adwaita- icon-theme.pc [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: mingw32-adwaita-icon-theme-3.14.1-1.fc22.noarch.rpm mingw64-adwaita-icon-theme-3.14.1-1.fc22.noarch.rpm mingw-adwaita-icon-theme-3.14.1-1.fc22.src.rpm mingw32-adwaita-icon-theme.noarch: E: non-readable /usr/i686-w64-mingw32/sys-root/mingw/share/icons/Adwaita/icon-theme.cache 0L mingw32-adwaita-icon-theme.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig/adwaita-icon-theme.pc mingw32-adwaita-icon-theme.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-adwaita-icon-theme.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig/adwaita-icon-theme.pc mingw64-adwaita-icon-theme.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- INFO: mock.py version 1.2.2 starting (python version = 3.4.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run ERROR: Build root is locked by another process. Diff spec file in url and in SRPM --------------------------------- --- /home/david/checkout/rpms/1169918-mingw-adwaita-icon-theme/srpm/mingw-adwaita-icon-theme.spec 2014-12-02 17:53:28.087738381 +0000 +++ /home/david/checkout/rpms/1169918-mingw-adwaita-icon-theme/srpm-unpacked/mingw-adwaita-icon-theme.spec 2014-12-02 16:48:09.000000000 +0000 @@ -13,6 +13,4 @@ BuildRequires: mingw32-filesystem >= 95 BuildRequires: mingw64-filesystem >= 95 -BuildRequires: mingw32-gcc -BuildRequires: mingw64-gcc BuildRequires: intltool BuildRequires: librsvg2 @@ -56,5 +54,4 @@ %doc AUTHORS COPYING README NEWS %{mingw32_datadir}/pkgconfig/adwaita-icon-theme.pc -%{mingw32_datadir}/icons/Adwaita %{mingw32_datadir}/icons/Adwaita/8x8 %{mingw32_datadir}/icons/Adwaita/16x16 @@ -75,5 +72,4 @@ %doc AUTHORS COPYING README NEWS %{mingw64_datadir}/pkgconfig/adwaita-icon-theme.pc -%{mingw64_datadir}/icons/Adwaita %{mingw64_datadir}/icons/Adwaita/8x8 %{mingw64_datadir}/icons/Adwaita/16x16 Requires -------- mingw32-adwaita-icon-theme (rpmlib, GLIBC filtered): mingw32-pkg-config pkgconfig mingw64-adwaita-icon-theme (rpmlib, GLIBC filtered): mingw64-pkg-config pkgconfig Provides -------- mingw32-adwaita-icon-theme: mingw32-adwaita-icon-theme mingw64-adwaita-icon-theme: mingw64-adwaita-icon-theme Source checksums ---------------- http://download.gnome.org/sources/adwaita-icon-theme/3.14/adwaita-icon-theme-3.14.1.tar.xz : CHECKSUM(SHA256) this package : b776a7ad58c97f4c1ede316e44d8d054105429cb4e3a8ec46616a14b11df48ee CHECKSUM(SHA256) upstream package : b776a7ad58c97f4c1ede316e44d8d054105429cb4e3a8ec46616a14b11df48ee Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1169918 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review