https://bugzilla.redhat.com/show_bug.cgi?id=1169898 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Looks good, but I'll echo what I mentioned in bug #1167062 1. the Obsoletes/Provides MUST to be versioned, options include: 1a. start kbrickbuster at some higher Release, like: Release: 10 combined with: Obsoletes: kbreakout < 4.14.3-10 Provides: kbreakout = %{version}-%{release} 1b. alternatively, to ensure it kbrickbuster always wins, could even introduce an Epoch in the Obsoletes/Provides, Obsoletes: kbreakout < 1:4.14.3-1 Provides: kbreakout = 1:%{version}-%{release} 2. Sources: Not ok, cannot verify. .spec currently includes: #Source0: http://download.kde.org/%{stable}/%{version}/src/%{name}-%{version}.tar.xz # patched source, rename the game Source0: kbrickbuster-4.14.3-rename.tar.xz SHOULD include a script to automate this renaming process. (doing this manually for every release would be tedious) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review