Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: memcached - High Performance, Distributed Memory Object Cache https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238994 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ruben@xxxxxxxxxxxxxxxx ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-05-05 07:10 EST ------- Hi Paul, I'm not a sponsor, but will give you some initial comments: - Perl is on the exception list, so no need to Require it (wiki: PackagingGuidelines#Exceptions) - Since you have a BuildRequires on libevent-devel, rpm creates a Requires: libevent, so there's no need to specify that. - I would suggest building with --with=threads by default, most servers are multiproc nowadays. What do you think? - At least drop the --with=threads part from the description. It's not very for the end-user. - Replace %{_sysconfdir}/rc.d/init.d with %{_initrddir} - Be consistent with $RPM_BUILD_ROOT or %{buildroot}, use one or the other, not both - Replace $RPM_BUILD_DIR/%{name}-%{version}/scripts/memcached.sysv with scripts/memcached.sysv in the %install section, there's no need to use $RPM_BUILD_DIR -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review