[Bug 1168419] Review Request: mingw-libgusb - GLib wrapper around libusb1 for MinGW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1168419

David King <amigadave@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> ---
All seems fine to me, except possibly the explicit pkg-config Requires. It is
not mentioned in the mingw packaging guidelines, so I do not know whether it is
necessary to depend on pkg-config directly, as the mingw32 and mingw64
subpackages have a Requires on mingw32-pkg-config and mingw64-pkg-config.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: mingw32-libgusb : /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1
  /gusb-private.h mingw32-libgusb : /usr/i686-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb.h mingw32-libgusb : /usr/i686-w64-mingw32
  /sys-root/mingw/include/gusb-1/gusb/gusb-context-private.h mingw32-libgusb :
  /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context.h
  mingw32-libgusb : /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb
  /gusb-device-list.h mingw32-libgusb : /usr/i686-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb/gusb-device-private.h mingw32-libgusb :
  /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device.h
  mingw32-libgusb : /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb
  /gusb-source.h mingw32-libgusb : /usr/i686-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb/gusb-util.h mingw32-libgusb :
  /usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-version.h
  mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1
  /gusb-private.h mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb.h mingw64-libgusb : /usr/x86_64-w64-mingw32
  /sys-root/mingw/include/gusb-1/gusb/gusb-context-private.h mingw64-libgusb :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context.h
  mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb
  /gusb-device-list.h mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb/gusb-device-private.h mingw64-libgusb :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device.h
  mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb
  /gusb-source.h mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-
  root/mingw/include/gusb-1/gusb/gusb-util.h mingw64-libgusb :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-version.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: mingw32-libgusb, mingw32-libgusb-static,
  mingw64-libgusb, mingw64-libgusb-static. Illegal package name:
  mingw32-libgusb, mingw64-libgusb. Does not provide -static: mingw32-libgusb,
  mingw64-libgusb.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

Not a problem for mingw packages.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 1
     files have unknown license. Detailed output of licensecheck in
     /home/david/checkout/rpms/1168419-mingw-libgusb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/x86_64-w64-mingw32/sys-root,
     /usr/i686-w64-mingw32/sys-root/mingw, /usr/x86_64-w64-mingw32,
     /usr/i686-w64-mingw32/sys-root/mingw/lib, /usr/i686-w64-mingw32,
     /usr/i686-w64-mingw32/sys-root, /usr/x86_64-w64-mingw32/sys-root/mingw,
     /usr/x86_64-w64-mingw32/sys-root/mingw/lib

Owned by the mingw-filesystem packages.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     mingw32-libgusb , mingw32-libgusb-static , mingw64-libgusb , mingw64
     -libgusb-static

Not necessary for noarch mingw packages.

[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
     Note: mingw64-libgusb : /usr/x86_64-w64-mingw32/sys-
     root/mingw/lib/pkgconfig/gusb.pc mingw32-libgusb : /usr/i686-w64-mingw32
     /sys-root/mingw/lib/pkgconfig/gusb.pc

Fine in the mingw case.

[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: mingw32-libgusb-0.2.2-1.fc22.noarch.rpm
          mingw32-libgusb-static-0.2.2-1.fc22.noarch.rpm
          mingw64-libgusb-0.2.2-1.fc22.noarch.rpm
          mingw64-libgusb-static-0.2.2-1.fc22.noarch.rpm
          mingw-libgusb-0.2.2-1.fc22.src.rpm
mingw32-libgusb.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb-private.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/gusb.pc
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device-private.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw32-libgusb.noarch: W: spurious-executable-perm
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-util.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context-private.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device-list.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-source.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-version.h
mingw32-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context.h
mingw32-libgusb.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
mingw32-libgusb-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgusb.a
mingw32-libgusb-static.noarch: W: no-documentation
mingw32-libgusb-static.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
mingw64-libgusb.noarch: E: arch-independent-package-contains-binary-or-object
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-util.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/gusb.pc
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb-private.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device-private.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-version.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw64-libgusb.noarch: W: spurious-executable-perm
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgusb.dll.a
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-context-private.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-source.h
mingw64-libgusb.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gusb-1/gusb/gusb-device-list.h
mingw64-libgusb.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw64-libgusb-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgusb.a
mingw64-libgusb-static.noarch: W: no-documentation
mingw64-libgusb-static.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw-libgusb.src: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib
mingw-libgusb.src: W: spelling-error %description -l en_US GUsb -> Gust, Gush,
Gus
mingw-libgusb.src: W: spelling-error %description -l en_US mainloop -> main
loop, main-loop, maintop
mingw-libgusb.src: W: strange-permission libgusb-0.2.2.tar.xz 0444L
mingw-libgusb.src:70: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 70)
5 packages and 0 specfiles checked; 4 errors, 37 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@lenovodave /]# rpmlint
mingw32-libgusb-static mingw64-libgusb-static mingw 
64-libgusb mingw32-libgusb
mingw32-libgusb-static.noarch: W: no-documentation
mingw64-libgusb-static.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
]0;<mock-chroot><mock-chroot>[root@lenovodave /]# echo 'rpmlint-done:'



Requires
--------
mingw32-libgusb-static (rpmlib, GLIBC filtered):
    mingw32-libgusb

mingw64-libgusb-static (rpmlib, GLIBC filtered):
    mingw64-libgusb

mingw64-libgusb (rpmlib, GLIBC filtered):
    mingw64(kernel32.dll)
    mingw64(libgio-2.0-0.dll)
    mingw64(libglib-2.0-0.dll)
    mingw64(libgobject-2.0-0.dll)
    mingw64(libusb-1.0.dll)
    mingw64(msvcrt.dll)
    mingw64-crt
    mingw64-filesystem
    mingw64-pkg-config
    pkgconfig

mingw32-libgusb (rpmlib, GLIBC filtered):
    mingw32(kernel32.dll)
    mingw32(libgio-2.0-0.dll)
    mingw32(libglib-2.0-0.dll)
    mingw32(libgobject-2.0-0.dll)
    mingw32(libusb-1.0.dll)
    mingw32(msvcrt.dll)
    mingw32-crt
    mingw32-filesystem
    mingw32-pkg-config
    pkgconfig



Provides
--------
mingw32-libgusb-static:
    mingw32-libgusb-static

mingw64-libgusb-static:
    mingw64-libgusb-static

mingw64-libgusb:
    mingw64(libgusb-2.dll)
    mingw64-libgusb

mingw32-libgusb:
    mingw32(libgusb-2.dll)
    mingw32-libgusb



Source checksums
----------------
http://people.freedesktop.org/~hughsient/releases/libgusb-0.2.2.tar.xz :
  CHECKSUM(SHA256) this package     :
5b39a109473a2a84827f06913b1eaba43a718a5025e7cb1fe4515a871476c321
  CHECKSUM(SHA256) upstream package :
5b39a109473a2a84827f06913b1eaba43a718a5025e7cb1fe4515a871476c321


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1168419
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]