https://bugzilla.redhat.com/show_bug.cgi?id=1167460 --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Mukundan Ragavan from comment #5) > Hi! Here is the detailed review. A few problems that need fixing. Thank you for the review. I think I fixed or justified everything. Specific comments below. > [?]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. This is private python libraries. They are not in ld path. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/doc/python-pygraphviz Damn, those last minute changes. Fixed. > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > ---> I suggest some changes under this - > > python2 setup.py ... could be changed to use macros. > > %{__python2}, %{__python3} I don't think that it matter to much, but I changed to %{__python2} and %{__python3}. > Generic: > [!]: Uses parallel make %{?_smp_mflags} macro. Added to make invocation. > [x]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > python3-pygraphviz , python-pygraphviz-doc > > ---> This looks fine to me. Yes, those packages are functionally independent. > Rpmlint > ------- > Checking: python-pygraphviz-1.3rc2-1.fc22.x86_64.rpm > python3-pygraphviz-1.3rc2-1.fc22.x86_64.rpm > python-pygraphviz-doc-1.3rc2-1.fc22.noarch.rpm > python-pygraphviz-1.3rc2-1.fc22.src.rpm > python-pygraphviz.x86_64: E: invalid-version 1.3rc2 > python3-pygraphviz.x86_64: E: invalid-version 1.3rc2 > python-pygraphviz-doc.noarch: E: invalid-version 1.3rc2 > > > ---> Version should not contain alpha, rc, etc. tags. You will have to > update the package using epoch tags. move rc2 to release tag. Yeah. Still waiting for upstream release. > python-pygraphviz-doc.noarch: E: zero-length > /usr/share/doc/python-pygraphviz/html/_static/empty.txt > > ---> Is this file needed? Doesn't seem to be. Removed in %prep. > python-pygraphviz-doc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python-pygraphviz/html/_static/jquery.js > > > ---> Please fix this. This is bundled jquery. I added 'Provides: bundled(jquery)' as described by https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries. > python-pygraphviz.src: E: invalid-version 1.3rc2 > 4 packages and 0 specfiles checked; 5 errors, 1 warnings. Spec URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz-1.3rc2-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review