https://bugzilla.redhat.com/show_bug.cgi?id=1168260 --- Comment #2 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- (In reply to Petr Šabata from comment #1) > The standalone SPEC differs from the one the SRPM. > It's just a different e-mail address in the changelog so I'll proceed with > the review. > > Wrong deps, both build-time and run-time. > Missing BRs: > - perl, called in SPEC > - perl(strict), used at %check phase > Useless runtime dependency: > - perl(Test::More), only used by the test suite > > `Debian' should be capitalized, in both Summary and %description. > > PERL_INSTALL_ROOT can be substituted with a more common DESTDIR. > > You don't need to remove empty directories (line 28). > > You wouldn't need to remove .packlist files (line 27) if you bumped the > ExtUtils::MakeMaker dependency to 6.76+ and added NO_PACKLIST=1 to the > Makefile.PL call (line 22). This would only work in F21 and newer, however. thank you for review. This is my first perl package, so I didn't know what's right. I'll fix all at this evening. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review