[Bug 1066613] Review Request: gtkdialog - Fast and easy GUI builder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066613



--- Comment #27 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> 3) Recommended to use patch file name starting with %{name}-%{version}
> so use it as
> Patch0:        %{name}-%{version}-fix_for_make_install.patch

Ill-advised, and it is not what most packagers have been doing for several
years at Red Hat Linux and the Fedora Project.

Better get used to *no* macros at all in patch file names. Why? For many
thousands of patch files, they still apply fine even when %version changes. Not
so, if you use a %version macro in the Patch tag. You would need to rename the
patch files in git and touch the spec file, too, just to make the patch apply
again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]