https://bugzilla.redhat.com/show_bug.cgi?id=1166919 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Miroslav Suchý from comment #1) > I believe that: > %if 0%{?fedora} >= 12 || 0%{?rhel} >= 8 > should be: > %if 0%{?fedora} >= 21 || 0%{?rhel} >= 8 > Correct? I had a reviewer of a previous python package insist that I put that at the top, because Fedora first introduced python 3 in F-12, and RHEL is expected to add python 3 in the next release (RHEL 8). It doesn't really matter to me. I do not intend to submit this package to EPEL, but added that in case somebody else wants to do so. If I was smart enough to figure out how to make the conditional read "This is either Fedora, or it is RHEL and the RHEL version is 8 or higher," I would do that instead and drop the 12 altogether. But I'm not quite sure how to do that. (In reply to Miroslav Suchý from comment #2) > Sorry just learn about %license. But anyway - it should be: > %doc CHANGELOG README.md > %license LICENSE No, the spec file is correct as it is written. The paths for these files refers to the source path (i.e., where the files are located at RPM creation time), not where they will be in the final package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review