[Bug 1166925] Review Request: perl-Plack-Middleware-RemoveRedundantBody - Plack::Middleware which sets removes body for HTTP response if it's not required

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1166925

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpmlint ./perl-Plack-Middleware-FixMissingBodyInRedirect*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok


$ rpm -qp --requires
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Plack::Middleware)
      1 perl(Plack::Util)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-Plack-Middleware-RemoveRedundantBody-0.05-1.fc22.noarch.rpm | sort | uniq
-c
      1 perl(Plack::Middleware::RemoveRedundantBody) = 0.04
      1 perl-Plack-Middleware-RemoveRedundantBody = 0.05-1.fc22

The version of Plack::Middleware::RemoveRedundantBody should be 0.05.

Author forgot to update VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:7:our $VERSION = "0.04";

Version was updated only at POD
./lib/Plack/Middleware/RemoveRedundantBody.pm:40:=head1 VERSION
./lib/Plack/Middleware/RemoveRedundantBody.pm:42:version 0.05


TODO: Please report it to upstream

Otherwise package looks good.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]