[Bug 1167041] Review Request: nodejs-tern - JavaScript code analyzer for deep, cross-editor language support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1167041



--- Comment #7 from Gerard Ryan <gerard@xxxxxxx> ---
Spec URL: https://galileo.fedorapeople.org/nodejs-tern/0.7.0-3/nodejs-tern.spec
SRPM URL:
https://galileo.fedorapeople.org/nodejs-tern/0.7.0-3/nodejs-tern-0.7.0-3.fc22.src.rpm

(In reply to Tom Hughes from comment #6)
> I think we have generally been using %{_datadir}/%{name} which would be
> nodejs-tern rather than tern, but that is the general idea, yes.

Done.

> I would leave out test I think. You may also want to symlink to some of them
> from %{_bindir}, especially tern as I think the emacs extensions will need
> to be able to start that.

Done.

> I think you're right that case 2 applies and you should require
> emacs-filesystem and do it in the main package.
> 
> Note you'll need to drop a file (tern-init.el or something) in site-start.d
> with the autoload line form http://ternjs.net/doc/manual.html#emacs in it.
> You won't need the add-to-list for load-path as /usr/share/emacs/site-lisp
> will already be on the path.

Done (and tested that "M-x tern-mode" works fine in emacs).

> No problem. I do have a few node package reviews of my own open if you feel
> like reciprocating ;-)

Of course! I'll have a look at the tracker bug this week & see what ones I can
do for you. Thanks again! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]