[Bug 1115704] Review Request: nodejs-sauce-tunnel - A wrapper around the Sauce Labs tunnel jar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115704

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |piotr1212@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
some first comments:

latest available version is 2.1.0, package is 2.0.6, can you update to latest
version?

add rm -rf vendor/ in %prep

Buildrequires are not needed for building, only when running with tests, you
could make them conditional as you did in nodejs-saucelabs.

set correct buildarch/exclusivearch, same as in nodejs-saucelab package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]