https://bugzilla.redhat.com/show_bug.cgi?id=1166984 --- Comment #3 from David Dick <ddick@xxxxxxxx> --- (In reply to Petr Šabata from comment #2) > TIP: Move COPYRIGHT from %doc to %license (f21+). I'd rather skip this as i'm planning on EPEL/f20 builds for this module > FIX: BuildRequire %{_bindir}/iconv. > > TODO: Useless BR -- ExtUtils::MakeMaker; you don't use the Makefile.PL at > all. > > TODO: You don't need to BR Getopt::Long or Net::IDN::Punycode either. The > pwhois utility is not tested and the build script doesn't check for > dependencies. > > TODO: Useless explicit Requires in the main package; only the pwhois > subpackage requires Net::IDN::Punycode. > > TODO: Also, none of the tests seems to do any live testing, therefore > there's no need to BR HTTP::Headers, HTTP::Request, LWP::UserAgent or > URI::URL. > > FIX: You still need to explicitly Require these as they will not be > autodetected. And not just them -- rpmbuild also misses Data::Dumper. > > TODO: I don't really like the %description of pwhois. I don't think it's > the right place to list all the switches and such. > > FIX: Since the pwhois subpackage doesn't explicitly require the main > package, put COPYRIGHT in its %license or %doc too. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review