https://bugzilla.redhat.com/show_bug.cgi?id=1166670 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok Source archive is original (SHA-256: 48b07c07ec14a79a69b8505f6d91c7449f5144eabe8fd606e43fbec7f932b03c). Ok. License verified from LICENSE, README, and lib/Lingua/EN/FindNumber.pm. Ok. Summary verified from lib/Lingua/EN/FindNumber.pm. Ok. Description verified from lib/Lingua/EN/FindNumber.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Use can use plain `perl' command instead of `%__perl' macro in the %build section. All build-time dependencies are declared. Ok. All tests pass. Ok. $ rpmlint perl-Lingua-EN-FindNumber.spec ../SRPMS/perl-Lingua-EN-FindNumber-1.30-1.fc22.src.rpm ../RPMS/noarch/perl-Lingua-EN-FindNumber-1.30-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Lingua-EN-FindNumber-1.30-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Nov 24 17:17 /usr/share/doc/perl-Lingua-EN-FindNumber -rw-r--r-- 1 root root 392 Jun 22 09:45 /usr/share/doc/perl-Lingua-EN-FindNumber/Changes -rw-r--r-- 1 root root 385 Jun 22 09:45 /usr/share/doc/perl-Lingua-EN-FindNumber/README drwxr-xr-x 2 root root 0 Nov 24 17:17 /usr/share/licenses/perl-Lingua-EN-FindNumber -rw-r--r-- 1 root root 18347 Jun 22 09:45 /usr/share/licenses/perl-Lingua-EN-FindNumber/LICENSE -rw-r--r-- 1 root root 2033 Nov 24 17:17 /usr/share/man/man3/Lingua::EN::FindNumber.3pm.gz drwxr-xr-x 2 root root 0 Nov 24 17:17 /usr/share/perl5/vendor_perl/Lingua drwxr-xr-x 2 root root 0 Nov 24 17:17 /usr/share/perl5/vendor_perl/Lingua/EN -rw-r--r-- 1 root root 3494 Jun 22 09:45 /usr/share/perl5/vendor_perl/Lingua/EN/FindNumber.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Lingua-EN-FindNumber-1.30-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl >= 0:5.006 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(base) 1 perl(Exporter) 1 perl(Lingua::EN::Words2Nums) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Lingua-EN-FindNumber-1.30-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Lingua::EN::FindNumber) = 1.30 1 perl-Lingua-EN-FindNumber = 1.30-1.fc22 Binary provides are Ok. $ resolvedeps f22-build ../RPMS/noarch/perl-Lingua-EN-FindNumber-1.30-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8220439). Ok. Otherwise the package in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review