[Bug 1066613] Review Request: gtkdialog - Fast and easy GUI builder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066613



--- Comment #19 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) I see mock build failed. You still have following. Un-comment it.
#rm %{buildroot}%{_datadir}/info/dir

2) Can you align the spec tag's and its value as
-------------------------------------------------------------
Name:          gtkdialog
Version:       0.8.3
Release:       5%{?dist}
Summary:       Fast and easy GUI builder
License:       GPLv2
URL:           https://code.google.com/p/gtkdialog/
Source:        https://gtkdialog.googlecode.com/files/%{name}-%{version}.tar.gz

Patch0:        gtkdialog_fix_for_make_install.patch

BuildRequires: libglade2-devel
BuildRequires: gtk2-devel
BuildRequires: vte-devel
BuildRequires: flex
BuildRequires: bison
BuildRequires: glib2-devel
BuildRequires: byacc

Requires(post): info
Requires(preun):info
----------------------------------------------------------------

3) Recommended to use patch file name starting with %{name}-%{version} so use
it as
Patch0:        %{name}-%{version}-fix_for_make_install.patch

Otherwise package looks good now. And as given in docs it needs some shell
scrip program which actually invoke gtkdialog binary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]