https://bugzilla.redhat.com/show_bug.cgi?id=1115703 --- Comment #2 from Ralph Bean <rbean@xxxxxxxxxx> --- Hi Piotr, thanks! I made some changes, but not all. To explain: - Empty debug package is created. - noarch took care of this: http://koji.fedoraproject.org/koji/taskinfo?taskID=8220043 - BuildArch: noarch needs to be specified, eg: BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif - Agreed -- done! - %description can be improved, e.g. make it %{summary}. - Agreed -- done! - %nodejs_symlink_deps --build can be ommited in %{build} - I'd like to leave this, even if it is a no-op, so that it stays symmetric with my other node packages. -- A new release of the package with the changes above can be found here: Spec URL: http://threebean.org/rpm/SPECS/nodejs-saucelabs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-saucelabs-0.1.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review