https://bugzilla.redhat.com/show_bug.cgi?id=1115703 Piotr Popieluch <piotr1212@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@xxxxxxxxx --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- Some comments: - Empty debug package is created. - BuildArch: noarch needs to be specified, eg: BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif - %description can be improved, e.g. make it %{summary}. - %nodejs_symlink_deps --build can be ommited in %{build} I can do a full review later this week when you fix those issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review