https://bugzilla.redhat.com/show_bug.cgi?id=1167041 --- Comment #5 from Gerard Ryan <gerard@xxxxxxx> --- (In reply to Tom Hughes from comment #4) > The files in the defs directory should maybe go in > %{_datadir} though and then be symlinked into the node library directory. Ok, so the files inside defs/ should go directly into %{_datadir}/tern/ and then symlinked from there back to %{nodejs_sitelib}/tern/defs/ ? > Also does it make sense to package anything in bin? Hmm, actually yes tern, condense, and from_ts from bin/ should probably all be packaged. bin/test comes with the module as downloaded from npm...should I just include the entire dir? > or the emacs files as a subpackage? I was looking at that initially, but I must have gotten distracted. I've never created a package for emacs (even my first js/nodejs packaging started yesterday!). A subpackage seems like a good approach, but reading the packaging guidelines for emacs[1], this sounds like "Case 2", for which it says: > Where a package's principal functionality does not require (X)Emacs, but the package also includes some auxiliary Elisp files to provide support for the package in (X)Emacs, these should be included in the main package which will need to Require the emacs-filesystem and/or xemacs-filesystem packages. So, is a subpackage acceptable, or would the main package need to have the files & depend on emacs-filesystem? If subpackage, is nodejs-tern-emacs acceptable? Or do you know of a way that we could have a subpackage that looks like an emacs package, like emacs-tern or something? Thanks again for reviewing, and any help you can provide. Purely for context: I'm mainly just packaging this as a dependency for the Eclipse plugin that bundles it, that I need as a new dependency for another Eclipse plugin. [1] https://fedoraproject.org/wiki/Packaging:Emacs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review