https://bugzilla.redhat.com/show_bug.cgi?id=1066613 --- Comment #15 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Can you please add full changelog for every new release? I see you are just adding "Fixes". Now when I want to check what has changed from last release, there is no information where to look into the spec file. Some other improvements: 1) After looking into this program usage, a question, why we need to install icon files if this not that end user need to execute directly? Also we don't need desktop file so what is use case to have icon file installed? 2) doc files are added to both the packages. Let's install only required doc files. Use %files for both binary rpms as %files %{_bindir}/gtkdialog %{_datadir}/icons/hicolor/32x32/apps/gtkdialog.png %doc AUTHORS ChangeLog COPYING NEWS README TODO %exclude %{_pkgdocdir}/examples %exclude %{_pkgdocdir}/reference %files doc %{_datadir}/info/%{name}.info.gz %{_pkgdocdir}/ %exclude %{_pkgdocdir}/AUTHORS %exclude %{_pkgdocdir}/ChangeLog %exclude %{_pkgdocdir}/COPYING %exclude %{_pkgdocdir}/NEWS %exclude %{_pkgdocdir}/README %exclude %{_pkgdocdir}/TODO 3) now to work for using %make_install, you need to remove makefile rules that causes compilation error when used %make_install. Add to end of %prep as sed -i '3,8d' data/icons/hicolor/Makefile.am autoreconf -ivf %configure now to use autoreconf, you need to add BuildRequires: autoconf BuildRequires: automake and then in %install replace %makeinstall with %make_install 4) I did a scratch build with above changes and it failed for missing makeinfo command. So now add BuildRequires: texinfo Just check what I suggested working for you also :) Submit new srpm with what has changed since last srpm in changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review