Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: taxipilot - Game where you pilot a taxi in space https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237813 karlikt@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From karlikt@xxxxxxxxx 2007-05-04 09:29 EST ------- (In reply to comment #7) > (In reply to comment #5) > Thanks for the review! > > > Before approve, please write any good reason for avoid deleting the libtool > > archives form package > > As already explained in both the specfile and a comment, .la files should not be > deleted from kde-libraries, for example see the output of: > rpm -ql kdelibs | grep '\.la' > Also see: > http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7 > Which explicitly mentions an exception for kde packaghes. So I quote: [Comment from mschwendt: It is not that easy, unfortunately, to kill libtool dependency bloat this way. Some software needs libtool archives at ***RUN-TIME*** because it uses an old libltdl to dlopen DSOs or uses a broken libltdl (like KDE bug #93359).] If it doesn't need .la at run-time (works OK), it can be IMHO removed. If you think that the .la files are needed for working, Guidelines can be ignored. + > and check working without game_data_tag. > Quoting myself from comment #2: > > E: taxipilot zero-length /usr/share/apps/taxipilot/game_data/game_data_tag > This file is needed and must stay Ops, I overlooked it. Sorry :) + APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review