https://bugzilla.redhat.com/show_bug.cgi?id=1166667 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 686556797cd2a4eaa066f19bbf03ab25c06278292c9ead2f187dfd9031ea1d85). Ok. License verified from README and Words2Nums.pm. Ok. Summary verified from Words2Nums.pm. Ok. Description verified from Words2Nums.pm. Ok. No XS code, noarch BuildArch is Ok. All build-requires are declared. Ok. All tests pass. Ok. $ rpmlint perl-Lingua-EN-Words2Nums.spec ../SRPMS/perl-Lingua-EN-Words2Nums-0.18-1.fc22.src.rpm ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Nov 21 15:21 /usr/share/doc/perl-Lingua-EN-Words2Nums -rw-r--r-- 1 root root 439 Dec 17 2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/README -rw-r--r-- 1 root root 311 Dec 17 2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/TODO -rw-r--r-- 1 root root 2486 Dec 17 2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/samples -rw-r--r-- 1 root root 263 Dec 17 2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/testnum -rw-r--r-- 1 root root 2021 Nov 21 15:21 /usr/share/man/man3/Lingua::EN::Words2Nums.3pm.gz drwxr-xr-x 2 root root 0 Nov 21 15:21 /usr/share/perl5/vendor_perl/Lingua drwxr-xr-x 2 root root 0 Nov 21 15:21 /usr/share/perl5/vendor_perl/Lingua/EN -rw-r--r-- 1 root root 8159 Dec 17 2008 /usr/share/perl5/vendor_perl/Lingua/EN/Words2Nums.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Lingua::EN::Words2Nums) 1 perl-Lingua-EN-Words2Nums = 0.18-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8202029). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review