[Bug 1165299] Review Request: paratype-pt-serif-fonts - PT Serif fonts by Paratype, a pan-Cyrillic typeface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1165299

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

- rpmlint on generated rpms gave output
paratype-pt-serif-caption-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/paratype-pt-serif-caption-fonts/PTSSM_OFL.txt
paratype-pt-serif-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/paratype-pt-serif-fonts/PTSSM_OFL.txt
paratype-pt-serif-fonts.src: W: unexpanded-macro %description -l C %_font_pkg
paratype-pt-serif-fonts.src: W: unexpanded-macro %description -l C %doc
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US conf ->
con, cone, cons
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US ttf ->
Flatt, 
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US txt ->
text, ext, tit
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US usr ->
use, us, user
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US appdata ->
app data, app-data, tapped
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US metainfo
-> meta info, meta-info, infotainment
paratype-pt-serif-fonts.src: W: spelling-error %description -l en_US xml ->
XML, ml, x ml
3 packages and 0 specfiles checked; 0 errors, 11 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: e7a2a27ed0481d20973f0d3b589362d055269082e3fc4d96f81dacd58bad8dcc
upstream tarball:
e7a2a27ed0481d20973f0d3b589362d055269082e3fc4d96f81dacd58bad8dcc

+ License is "OFL" and included in its own text file.

+ follows fonts packaging guidelines.

Suggestions to fix issues:-
1) you should take version as a date on which you packages. So it should be
20141119.

Generally if there is no version in tarball then take that as snapshot package
with its version as YYYYMMDD.

2) rpmlint warning wrong-file-end-of-line-encoding can be fixed in %prep
sed -i "s|\r||g" PTSSM_OFL.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]