[Bug 1165300] Review Request: paratype-pt-mono-fonts - PT Mono fonts by Paratype, a monospaced typeface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1165300

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successful in mock (f22 x86_64)

- rpmlint on generated rpms gave output
paratype-pt-mono-fonts.noarch: W: spelling-error Summary(en_US) monospace ->
mono space, mono-space, aerospace
paratype-pt-mono-fonts.noarch: W: spelling-error %description -l en_US
superfamily -> super family, super-family, superficially
paratype-pt-mono-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/paratype-pt-mono-fonts/PTSSM_OFL.txt
paratype-pt-mono-fonts.src: W: spelling-error Summary(en_US) monospace -> mono
space, mono-space, aerospace
paratype-pt-mono-fonts.src: W: unexpanded-macro %description -l C %_font_pkg
paratype-pt-mono-fonts.src: W: unexpanded-macro %description -l C %doc
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US superfamily
-> super family, super-family, superficially
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US conf ->
con, cone, cons
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US ttf ->
Flatt, 
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US txt ->
text, ext, tit
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US usr -> use,
us, user
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US appdata ->
app data, app-data, tapped
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US metainfo ->
meta info, meta-info, infotainment
paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US xml -> XML,
ml, x ml
2 packages and 0 specfiles checked; 0 errors, 14 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball:e34e729f9509cf85acc52caadf68e96db90457b7164ba45719967d53e7a20dcc
upstream
tarball:e34e729f9509cf85acc52caadf68e96db90457b7164ba45719967d53e7a20dcc

+ License is "OFL" and included in its own text file.

+ follows fonts packaging guidelines.


Suggestions to fix issues
1) you should take version as a date on which you packages. So it should be
20141119.

Generally if there is no version in tarball then take that as snapshot package
with its version as YYYYMMDD.

2) rpmlint warning wrong-file-end-of-line-encoding can be fixed in %prep
sed -i "s|\r||g" PTSSM_OFL.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]