https://bugzilla.redhat.com/show_bug.cgi?id=1165641 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- Since the btparse library is available as a standalone project, you should really package it separately, unbundle it and depend on the other btparse package. You'll also have to patch Build.PL to use the external library. I'll comment on the rest for now. #1 btool_faw.pod seems to be useful. Add it to %doc. #2 Some BRs are missing. >From Build.PL and inc/MyBuilder.pm (loaded by Build.PL): perl(base), perl(Config), perl(ExtUtils::Mkbootstrap), perl(ExtUtils::ParseXS), perl(File::Copy), perl(File::Path), perl(File::Spec::Functions) and perl(lib). #3 Tip: That shebang substitution could be done in one go, e.g. sed -ri 's#/usr/local/bin/perl5?#%{__perl}#' scripts/* examples/*; and similar for that chmod. #4 About your first FIXME: Indeed, you should move this to a separate package, see above. #5 About your second FIXME: These are also provided by btparse. We probably want them but not here. #6 About your third FIXME: `xscode' is a mapping between the perl code and the C library. It creates the BibTeX.so file. This is fine and you don't have to worry about it. #7 After you unbundle the library, you won't need chrpath nor %{_mandir}/man1/*, %{_bindir}/* and %{_libdir}/*.so in you %files section. This is probably obvious :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review