Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schismtracker - sound module composer/player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238824 ville.skytta@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(ville.skytta@xxxxx| |i) | ------- Additional Comments From ville.skytta@xxxxxx 2007-05-04 06:36 EST ------- (In reply to comment #4) > Updated. I'm using F7t4 on x86_64. Surprisingly it builds in mock successfully > even without any deps to X, so that the SDL-devel BuildRequire seems to be > sufficient. It is, but doing so leaves support for X, Xkb and Xv out (grep for USE_X in the source to see what that results in). Is this really desirable? If yes, X should be disabled explicitly by passing --without-x to configure for reproducible builds. Otherwise, adding the build deps mentioned in comment 1 would get all X support built in. The "too many dirs owned" problem mentioned in comment 3 persists. Now that the hicolor-icon-theme dep is there, the icon stuff in %files should be changed to eg. %{_datadir}/icons/hicolor/*x*/apps/%{name}.* "Name=Schism Tracker" would be better than "Name=Schismtracker" (to match the window title) in the .desktop file. .desktop Categories: Application (invalid) and X-Fedora (unused/unneeded) should be dropped, and "Audio" could be added in addition to "AudioVideo". http://standards.freedesktop.org/menu-spec/latest/apa.html -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review