https://bugzilla.redhat.com/show_bug.cgi?id=1142407 Tomas Mlcoch <tmlcoch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mchalk@xxxxxxxxxx | |) --- Comment #6 from Tomas Mlcoch <tmlcoch@xxxxxxxxxx> --- Hi Matej, few things: 1) Build I've got an error: drpm_compstrm.c:29:18: fatal error: lzma.h: No such file or directory #include <lzma.h> 2) BuildRequire lzma-sdk-devel This looks weird to me: BuildRequires: lzma-sdk-devel do you realy need lzma-sdk-deve? Wouldn't be the "lzma-devel" the appropriate build dep (this could also fix the build error)? 3) Unversioned .so The unversioned .so (libdrpm.so) should go into devel sub-package. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages 4) Package version in chagelogs Please include pkg version and release in changelogs. Also please keep the individual changelogs separated by one newline for better readability. (Also, it is a good convention to include your whole name before the email address) See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 5) Devel package should require the base package So please add the line to devel package: Requires: %{name}%{?_isa} = %{version}-%{release} See: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Suggestion: a) It would be nice to have a drpm.pc (pkgconfig file) for pkg-config tool in the devel sub-package as well. b) Add address of upstream git repo to the project homepage. (https://fedorahosted.org/drpm/). I've noticed that my drpm checkout from the very beginning of drpm development is not up to date with source code in the srpm you have pasted here (at least the Makefile is different) and git pull doesn't pull any changes. c) Makefile is fine for such small project, but if you plan to extend it, consider use of more sophisticated build system like the CMake. d) Consider of removing word "Current" from description. I think that the present is implicit and doesn't have to be specified explicitly. Mostly, we care about the package we have right now, we are not interested about its possible features in distant future. :) Tomas -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review