https://bugzilla.redhat.com/show_bug.cgi?id=1138130 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output nodejs-mustache.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-mustache.noarch: W: summary-not-capitalized C mustache.js is an implementation of the mustache template system in JavaScript nodejs-mustache.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-mustache.noarch: W: only-non-binary-in-usr-lib nodejs-mustache.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-mustache.src: W: summary-not-capitalized C mustache.js is an implementation of the mustache template system in JavaScript nodejs-mustache.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 7 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 602be26bb07629b07db996341ca231a831790c972c6ed35e6bfbd51957e096a9 upstream tarball: 602be26bb07629b07db996341ca231a831790c972c6ed35e6bfbd51957e096a9 + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Adjust summary wording to get it started with Capitalized letter. Like "An implementation of the mustache template system in JavaScript". also, Good to add more information in %description as "Mustache is a logic-less template syntax. It can be used for HTML, config files, source code - anything. It works by expanding tags in a template using values provided in a hash or object. We call it "logic-less" because there are no if statements, else clauses, or for loops. Instead there are only tags. Some tags are replaced with a value, some nothing, and others a series of values." 2) I still think conditional test should be executed in %check and not the other way. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review