https://bugzilla.redhat.com/show_bug.cgi?id=1161109 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-events.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-events.noarch: W: only-non-binary-in-usr-lib nodejs-events.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball: a8d3c4ea659a341628e3cc1c6ab73bce01363add8639dca612343c25632c3e5a upstream tarball: a8d3c4ea659a341628e3cc1c6ab73bce01363add8639dca612343c25632c3e5a + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) I think you should write tests in %check and not based on conditional execute %check. So, remove unnecessary %check on line 35. 2) Use in Node's in summary and description instead of nodes APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review