https://bugzilla.redhat.com/show_bug.cgi?id=1164483 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-filelist.noarch: W: spelling-error Summary(en_US) regexes -> regexps, reg exes, reg-exes nodejs-filelist.noarch: W: only-non-binary-in-usr-lib nodejs-filelist.noarch: W: dangling-symlink /usr/lib/node_modules/filelist/node_modules/minimatch /usr/lib/node_modules/minimatch nodejs-filelist.noarch: W: dangling-symlink /usr/lib/node_modules/filelist/node_modules/utilities /usr/lib/node_modules/utilities nodejs-filelist.src: W: spelling-error Summary(en_US) regexes -> regexps, reg exes, reg-exes 2 packages and 0 specfiles checked; 0 errors, 5 warnings. + Source0 verified with upstream as (sha256sum) srpm tarball: b1c7d61ab5cea2f75d290c9cba3f418ed3debc7bd19c4bcb1e4b8e09287693cb upstream tarball:b1c7d61ab5cea2f75d290c9cba3f418ed3debc7bd19c4bcb1e4b8e09287693cb + License is "ASL 2.0" and included in separate its own text file. + follows nodejs packaging guidelines. Suggestions: 1) I think you should write tests in %check and not based on conditional execute %check. So, %if 0%{?enable_tests} %check %nodejs_symlink_deps --check jake test %endif should be %check %if 0%{?enable_tests} %nodejs_symlink_deps --check jake test %endif APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review