[Bug 1165627] Review Request: perl-XML-LibXML-Simple - XML::LibXML clone of XML::Simple::XMLin()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1165627



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
#1 The same as bug 1165625, comment 3, point 3.

#2 The same as bug 1165625, comment 3, point 4.

#3 Missing build-time dependencies this time: perl, perl(base), perl(Carp),
perl(Data::Dumper), perl(Exporter), perl(File::Basename), perl(File::Spec),
perl(IO::File), perl(lib), perl(strict), perl(vars), perl(warnings).

#4 You don't need to explicitly Require perl(File::Slurp::Tiny).  rpmbuild
automatically detects this dependency for you; it doesn't always catch
everything, however, simple `use' statements like this
(lib/XML/LibXML/Simple.pm:18) are not a problem.

#5 Don't Require perl(Test::More).  This module is used at build-time only,
required by the test suite.

#6 rpmbuild also finds the perl(XML::LibXML) dependency but it doesn't know
what version this package needs as it doesn't say so in the code, only in the
META.* files.  You end up with two dependencies, one versioned, the one you
explicitly list, and one unversioned, added by rpmbuild:

$ rpm -qRp perl-XML-LibXML-Simple-0.94-1.fc22.noarch.rpm | grep XML::LibXML
perl(XML::LibXML)
perl(XML::LibXML) >= 1.64

You should filter out the unversioned dependency.  See
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Perl

For example, the following would do the trick for you:
%global __requires_exclude
%{?__requires_exclude|%__requires_exclude|}^perl\\(XML::LibXML\\)$

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]