https://bugzilla.redhat.com/show_bug.cgi?id=1165625 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- #1 Please, link to the SPEC file itself rather than to a webpage displaying it. This link would have been much better: https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-XML-Writer-String.spec #2 Look at the package before you submit it... 5 License: CHECK(GPL+ or Artistic) #3 The current version of cpanspec generates SPEC files with lots and lots of ancient, nowadays unneeded cruft. Most of it can be removed unless you want to support old EPEL versions as well (however, not even el5 needs all of that). I will assume you're packaging only for Fedora for now. If not, we'll fix that later. So: - the BuildRoot tag can be removed - cleaning the buildroot in the %install section is not needed either - the whole %clean section can be removed - %defattr in the %files section can be removed - and you don't need to remove possible empty directories #4 Modern ExtUtils::MakeMaker understands DESTDIR so you can use that instead of PERL_INSTALL_ROOT. If you're packaging only for f21+, you can also set NO_PACKLIST which will supress installation of .packlist files and therefore you won't need to remove them in %install. NO_PACKLIST requires perl(ExtUtils::MakeMaker) >= 6.76. In the end you would get something like: %build perl Makefile.PL INSTALLDIR=vendor NO_PACKLIST=1 make %{?_smp_mflags} %install make pure_install DESTDIR=$RPM_BUILD_ROOT %{_fixperms} $RPM_BUILD_ROOT/* #5 Now the license. It is indeed "GPL+ or Artistic" ("same as Perl"), so remove the "CHECK" from the License tag. #6 The packaged files use CRLF line endings. Convert them to Unix-style. There are various ways to do this. You choose. #7 Consider packaging the `example' directory as documentation. #8 There are some missing build-time dependencies: perl, perl(strict), perl(Test) and perl(warnings). perl is called in the SPEC file and the perl modules are used by the code at %check phase. Just because it builds now doesn't mean it will tomorrow. Listing all actual dependencies is a good practice. #9 Incorrect possesive form of "it" in %description, s/it's/its/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review