https://bugzilla.redhat.com/show_bug.cgi?id=1163440 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dvratil@xxxxxxxxxx Flags| |needinfo?(dvratil@xxxxxxxxx | |m) --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok lots of subpkgs going on there, but it looks pretty good, upgrade paths are obviously tricky, but I think it's mostly sorted out now. 1. SHOULD remove from kwin-oxygen: # Conflicts with kde-style-oxygen from kde-workspace Conflicts: kde-style-oxygen < 5.1.0-1 pretty sure this isn't true, and can be removed 2. SHOULD omit from qt4-style-oxygen and qt5-style-oxygen: Requires: oxygen-cursor-themes = %{version}-%{release} Requires: oxygen-sound-theme = %{version}-%{release} I don't think these are needed, the widget style is/(should-be?) independent of cursor-theme and sounds sources: ok fc112c113dedcbac338e0db89af4b388 oxygen-5.1.1.tar.xz macros: ok, though preferably 3. SHOULD use make install/fast DESTDIR=%{buildroot} rather than %make_install scriptlets: NOT OK 4. MUST add iconcache scriptlets to oxygen-cursor-themes subpkg license: ok , but I think from licensecheck output we could bump to GPLv2+ if you want -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review