https://bugzilla.redhat.com/show_bug.cgi?id=1135522 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dvratil@xxxxxxxxxx Flags| |needinfo?(dvratil@xxxxxxxxx | |m) --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- For the purpose of this review, I'll treat %global wayland 0 (still missing kf5-kwayland on f21 too) naming: ok 1. license: NOT OK, MUST use (something like): close, but there's one file: scripts/enforcedeco/contents/code/main.js that is the variant where we need: # all sources are effectively GPLv2+, except for: # scripts/enforcedeco/contents/code/main.js # KDE e.V. may determine that future GPL versions are accepted License: GPLv2 or GPLv3 macros: ok, though I personally prefer make install/fast DESTDIR=%{buildroot} -C %{_target_platform} over %make_install -C %{_target_platform} sources: ok 85ec15e6ce29b1bb80f376bc6914bc7c kwin-5.1.1.tar.xz 2. scriptlets: NOT OK, MUST add icon scriptlets, since we have in %files: %{_datadir}/icons/hicolor/*/apps/* https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 3. -doc subpkg SHOULD be noarch 4. SHOULD improve Conflicts: kde-workspace-devel Ideally, I'd like to avoid this altogether, but I suppose that may not be possible. If so, please make this versioned, even if just Conflicts: kde-workspace-devel < 5 I think the rest looks good, please address at least the MUST/blocker items... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review