[Bug 1164378] Review Request: pulse - Open Source Continuous File Synchronization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1164378



--- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi Javier, a few comments.

- Given that the source comes from Github is advisable use of the Source url
packaging guidelines, please see
http://fedoraproject.org/wiki/Packaging:SourceURL#Github
- Use %global instead %define, %define is deprecated.
- Description must not be over 80 columns per line
- Citing http://fedoraproject.org/wiki/PackagingDrafts/Go Binary packages which
build against this source will set $GOPATH to '%{_datadir}/gocode' ( or
'%{gopath}' in golang > 1.2.1-1)
- Try to separate the appropiate build method of the file build.sh. It is
simpler and clean.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]